IllegalStateException reading data with struct type #43
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
zhztheplayer
force-pushed
the
wip-struct-type
branch
from
79bd1e5 to
13e13c4
Compare
zhztheplayer
force-pushed
the
wip-struct-type
branch
from
5df6e48 to
b4a837b
Compare
| readLock.lock(); | ||
| try { | ||
| if (schema != null) { | ||
| return schema; | ||
| } |
There was a problem hiding this comment.
dup code on 132-134 vs 127-129?
There was a problem hiding this comment.
Sorry Yuan I missed the comment before merging.
The codes applies double-checked locking to balance between performance and atomicity. Although may look tedious as we don't usually have concurrent call to this method.
For example: schema can happen to be assigned by another thread before acquiring the lock. So we have to check again inside the lock.
No description provided.